Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revamp BOS component Dashboard Nav, BOS component explorer, introduce launchpad prototype, and added 404 fallback. #867

Merged
merged 21 commits into from
Jul 19, 2024

Conversation

Kevin101Zhang
Copy link
Contributor

@Kevin101Zhang Kevin101Zhang commented Jul 12, 2024

added BOS component launchpad, and a general 404 fallback.
revamped and integrated launchpad with new navigation with style reword for better alignment towards future styles

https://www.loom.com/share/bc9ed95387e5451f94fac65eac2bb146?sid=a3763829-bc5c-4c67-af06-9433762570f5

@Kevin101Zhang Kevin101Zhang linked an issue Jul 12, 2024 that may be closed by this pull request
@Kevin101Zhang Kevin101Zhang changed the title 794 create a design for queryapi homepage wizard feat: revamp BOS component Dashboard Nav, BOS component explorer, introduce launchpad prototype, and added 404 fallback. Jul 19, 2024
@Kevin101Zhang Kevin101Zhang marked this pull request as ready for review July 19, 2024 18:51
@Kevin101Zhang Kevin101Zhang requested a review from a team as a code owner July 19, 2024 18:51
@Kevin101Zhang Kevin101Zhang marked this pull request as draft July 19, 2024 18:52
@Kevin101Zhang Kevin101Zhang marked this pull request as ready for review July 19, 2024 19:01
@Kevin101Zhang
Copy link
Contributor Author

Kevin101Zhang commented Jul 19, 2024

Difficult make make in multiple PRs unfortunately with the nature of the PR. Many overlapping files and the transition from BOS state management of (State.init {xyz:1} and state.xyz) to more traditional supported react state
const [xyz, setXyz] = useState(1)

Copy link
Collaborator

@darunrs darunrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The launchpad looks nice! Good place to start for sure. I'll drop any suggestions I have in the slack channel. That said, the Loom did not show it so I wanted to confirm that the initial page is still Explore Indexers and not the launchpad. We should only switch to the Launchpad when it's complete. On that note, can you set a flag to not display the launchpad unless the env is dev? We should feature flag it for now until it's actually functional.

@Kevin101Zhang Kevin101Zhang merged commit 4ee7246 into main Jul 19, 2024
4 checks passed
@Kevin101Zhang Kevin101Zhang deleted the 794-create-a-design-for-queryapi-homepage-wizard branch July 19, 2024 20:28
@darunrs darunrs mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryAPI homepage wizard
2 participants