fix: fetch BOS indexerdata from near RPC call and conditionally render metadata if available in databricks #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevin101Zhang
changed the title
Kevin101Zhang
commented
Jul 17, 2024
|
|
||
| const fetchIndexerData = () => { | ||
| Near.asyncView(`${REPL_REGISTRY_CONTRACT_ID}`, "list_all").then((data) => { |
There was a problem hiding this comment.
To be replaced with indexer
darunrs
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
LGTM! To confirm my understanding, the new code now does:
- Fetch active indexers using RPC
- Fetch usage data for all indexers from some endpoint
- Pass active indexer list to some component as cards
- For each card, look at the map of usage data and populate usage if present
Did I get that right?
| @@ -175,11 +189,6 @@ return ( | |||
| <ButtonLink | |||
| primary | |||
| href={editUrl} | |||
| onClick={() => | |||
There was a problem hiding this comment.
Is this not necessary anymore? I think we use active tab in various places?
There was a problem hiding this comment.
the state did not exist on the page. I assumed maybe it was a hidden property passed from a parent but i didnt see anything of the sort. Removing it I did not see any differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOS component data is fetched from NEAR RPC call 'list_all'. We use a map to set a k/v pair for indexer metadata recieved on databricks. When we render each card we check the map to see if the indexer to be rendered from NEAR RPC exist in the map. If it does exist we conditionally render metadata.