Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding OKX wallet package #1117

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix: Adding OKX wallet package #1117

merged 2 commits into from
Jun 18, 2024

Conversation

trechriron
Copy link
Collaborator

@trechriron trechriron commented Jun 18, 2024 •
edited
Loading

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@trechriron trechriron self-assigned this Jun 18, 2024
@github-actions github-actions bot changed the title Adding OKX wallet package fix: Adding OKX wallet package Jun 18, 2024
andy-haynes
andy-haynes reviewed Jun 18, 2024
View reviewed changes
scripts/release-packages.bash Outdated
OTP=123456
TAG=latest
OTP=771522
TAG=8.9.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change these now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left there from last run. Updating.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left from last run. Fixed.

@andy-haynes andy-haynes merged commit 281b5ef into dev Jun 18, 2024
5 checks passed
@andy-haynes andy-haynes deleted the add-okx-package-fix branch June 18, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-haynes andy-haynes andy-haynes approved these changes

Assignees

@trechriron trechriron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trechriron @andy-haynes