Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed account id requirement for ledger connecting #256

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

amirsaran3
Copy link
Collaborator

@amirsaran3 amirsaran3 commented Apr 13, 2022

Description

Removed the need for users to input their account id when connecting with the Ledger Wallet. It now automatically fetches the account id connected with your public key you are connecting with and validates it. If there is no account id connected with public key you are trying to connect with it will show you an error message.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@amirsaran3 amirsaran3 added the change-request A request to change an existing component or feature label Apr 13, 2022
@amirsaran3 amirsaran3 added this to the Ledger Wallet Integration milestone Apr 13, 2022
@amirsaran3 amirsaran3 self-assigned this Apr 13, 2022
@github-actions github-actions bot changed the title task: Removed account id requirement for ledger connecting feat: Removed account id requirement for ledger connecting Apr 13, 2022
@amirsaran3 amirsaran3 merged commit 6e58624 into dev Apr 14, 2022
@amirsaran3 amirsaran3 deleted the SQAC-109-remove-account-id-requirement-for-ledger branch April 14, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change-request A request to change an existing component or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants