Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Decouple Modal State from Core #257

Merged
merged 23 commits into from
Apr 14, 2022

Conversation

lewis-sqa
Copy link
Contributor

@lewis-sqa lewis-sqa commented Apr 14, 2022

Description

  • Decoupled Modal specific state to use local variables and made an attempt at "routing".
  • Added back on and off for networkChanged scenario.
  • Added a custom error to signal cases such as wallet not installed.
  • Modified the Ledger view to have a back button instead of dismiss.
  • Moved show and hide methods to the modal "package" and refactored the directory structure.
  • Moved options out of state.
  • Removed restApiUrl from Network. Doesn't support betanet and requires more than just the URL to function (e.g. database password etc).
  • Realigned Angular example from feat: Expose State Methods for Modal UI (inc. Major API Changes) #243.

Links

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@lewis-sqa lewis-sqa self-assigned this Apr 14, 2022
@lewis-sqa lewis-sqa changed the base branch from dev to SQAC-107/expose-state-methods April 14, 2022 08:24
@lewis-sqa lewis-sqa marked this pull request as ready for review April 14, 2022 10:16
amirsaran3
amirsaran3 previously approved these changes Apr 14, 2022
@lewis-sqa lewis-sqa changed the base branch from SQAC-107/expose-state-methods to dev April 14, 2022 14:15
@lewis-sqa lewis-sqa dismissed amirsaran3’s stale review April 14, 2022 14:15

The base branch was changed.

@github-actions github-actions bot changed the title SQAC-123: Decouple Modal State from Core feat: Decouple Modal State from Core Apr 14, 2022
@lewis-sqa lewis-sqa merged commit fd01a3a into dev Apr 14, 2022
@lewis-sqa lewis-sqa deleted the SQAC-123/decouple-modal-state-from-core branch April 14, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants