Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Created utils package #265

Merged
merged 19 commits into from
May 17, 2022
Merged

refactor: Created utils package #265

merged 19 commits into from
May 17, 2022

Conversation

amirsaran3
Copy link
Collaborator

@amirsaran3 amirsaran3 commented Apr 20, 2022 •
edited
Loading

Description

Created a utils package and moved all common utility methods into it.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@amirsaran3 amirsaran3 added the change-request A request to change an existing component or feature label Apr 20, 2022
@amirsaran3 amirsaran3 added this to the React Best Practices milestone Apr 20, 2022
@amirsaran3 amirsaran3 self-assigned this Apr 20, 2022
@amirsaran3 amirsaran3 changed the title Created basic package, exported isMobile method and replaced is-mobi… Created utils package Apr 20, 2022
@amirsaran3 amirsaran3 marked this pull request as ready for review April 28, 2022 13:49
@github-actions github-actions bot changed the title Created utils package refactor: Created utils package May 11, 2022
lewis-sqa
lewis-sqa reviewed May 12, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
packages/core/src/lib/wallet/wallet.ts Outdated Show resolved Hide resolved
packages/wallet-utils/src/lib/wallet-utils.ts Outdated Show resolved Hide resolved
packages/wallet-utils/src/lib/wallet-utils.ts Outdated Show resolved Hide resolved
packages/wallet-utils/src/lib/wallet-utils.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/utils.ts Outdated Show resolved Hide resolved
packages/wallet-utils/README.md Outdated Show resolved Hide resolved
lewis-sqa
lewis-sqa reviewed May 17, 2022
View reviewed changes
packages/ledger/src/lib/ledger.ts Outdated Show resolved Hide resolved
packages/math-wallet/src/lib/math-wallet.ts Outdated Show resolved Hide resolved
@amirsaran3 amirsaran3 merged commit 44b08de into dev May 17, 2022
@amirsaran3 amirsaran3 deleted the SQAC-114-create-utils-package branch May 17, 2022 09:45
@lewis-sqa lewis-sqa mentioned this pull request May 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewis-sqa lewis-sqa lewis-sqa approved these changes

@rgolea rgolea Awaiting requested review from rgolea

@kujtimprenkuSQA kujtimprenkuSQA Awaiting requested review from kujtimprenkuSQA

Assignees

@amirsaran3 amirsaran3

Labels
change-request A request to change an existing component or feature
Projects
None yet
Milestone
Architecture Refactor
Development

Successfully merging this pull request may close these issues.
2 participants
@amirsaran3 @lewis-sqa