Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Close Modal by Pressing the ESC Key #269

Merged
merged 1 commit into from
Apr 21, 2022
Merged

chore: Close Modal by Pressing the ESC Key #269

merged 1 commit into from
Apr 21, 2022

Conversation

kujtimprenkuSQA
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA commented Apr 21, 2022 •
edited
Loading

Description

  • Close modal by pressing ESC key.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@kujtimprenkuSQA kujtimprenkuSQA self-assigned this Apr 21, 2022
@github-actions github-actions bot changed the title Close Modal by Pressing the ESC Key chore: Close Modal by Pressing the ESC Key Apr 21, 2022
@kujtimprenkuSQA kujtimprenkuSQA added enhancement New feature or request automerge labels Apr 21, 2022
@kujtimprenkuSQA kujtimprenkuSQA merged commit e9c6562 into dev Apr 21, 2022
@kujtimprenkuSQA kujtimprenkuSQA deleted the SQAC-135/close-modal-esc branch April 21, 2022 13:20
@lewis-sqa lewis-sqa mentioned this pull request May 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirsaran3 amirsaran3 amirsaran3 approved these changes

@rgolea rgolea Awaiting requested review from rgolea

Assignees

@kujtimprenkuSQA kujtimprenkuSQA

Labels
automerge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kujtimprenkuSQA @amirsaran3