-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor Wallet Implementations #276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
SQAC-141: Refactor Wallet Implementations
refactor: Refactor Wallet Implementations
May 4, 2022
kujtimprenkuSQA
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isAvailable
in favour of returningnull
during wallet setup (which is now async).wallets
tomodules
.selector.wallet()
to be async.wallet-controller
towallet-modules
&wallet-instance
.connect
anddisconnect
.connect
.getAccounts
instead ofconnect
to validate the connected status.signTransactions
method to Math Wallet._state
variable to hold references to clients and subscriptions.isAvailable
logic into the setup method.chainId
parameter to WalletConnect to avoid confusion when using custom network configuration.appMetadata
back tometadata
for WalletConnect.Future Improvements
options.network
and wallet network.WalletModuleFactory
to avoid wallets having to importis-mobile
.Checklist:
Type of change. This type of change is the main reason for the PR.
Breaking changes