Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor Wallet Implementations (Part 2) #278

Merged
merged 9 commits into from
May 6, 2022

Conversation

lewis-sqa
Copy link
Contributor

@lewis-sqa lewis-sqa commented May 5, 2022

Description

  • Fixed waitFor logic causing the selector to crash when the Sender or Math Wallet is not installed.
  • Fixed bug with Sender preventing disconnect when an error occurs.
  • Added check for duplicate module IDs.
  • Gracefully handle when modules throw during setup and initialise.
  • Updated Angular example.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@lewis-sqa lewis-sqa self-assigned this May 5, 2022
@github-actions github-actions bot changed the title SQAC-141: Refactor Wallet Implementations (Part 2) fix: Refactor Wallet Implementations (Part 2) May 5, 2022
@lewis-sqa lewis-sqa marked this pull request as ready for review May 6, 2022 07:48
@lewis-sqa lewis-sqa merged commit 1d5020a into dev May 6, 2022
@lewis-sqa lewis-sqa deleted the SQAC-141/refactor-wallet-implementations-2 branch May 6, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants