Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multiple Account Support for Ledger #282

Merged
merged 8 commits into from
May 11, 2022

Conversation

lewis-sqa
Copy link
Contributor

@lewis-sqa lewis-sqa commented May 11, 2022

Description

  • Added support for connecting to multiple accounts with Ledger.
  • Improved error messages.
  • Updated documentation.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@lewis-sqa lewis-sqa self-assigned this May 11, 2022
@lewis-sqa lewis-sqa changed the base branch from main to dev May 11, 2022 08:30
@lewis-sqa lewis-sqa marked this pull request as ready for review May 11, 2022 09:50
@github-actions github-actions bot changed the title SQAC-110: Multiple Account Support for Ledger feat: Multiple Account Support for Ledger May 11, 2022
@lewis-sqa lewis-sqa merged commit 4fcf79a into dev May 11, 2022
@lewis-sqa lewis-sqa deleted the SQAC-110/ledger-multi-account-support branch May 11, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants