Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signTransactions Improvements #294

Merged
merged 3 commits into from
May 20, 2022
Merged

fix: signTransactions Improvements #294

merged 3 commits into from
May 20, 2022

Conversation

lewis-sqa
Copy link
Contributor

@lewis-sqa lewis-sqa commented May 19, 2022 •
edited
Loading

Description

  • Added missing networkId parameter when calling signTransaction.
  • Added missing signerId for transformTransactions.
  • Fixed networkId parameter for getPublicKey incorrectly receiving nodeUrl.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@lewis-sqa lewis-sqa self-assigned this May 19, 2022
@lewis-sqa lewis-sqa marked this pull request as ready for review May 19, 2022 12:57
@github-actions github-actions bot changed the title signTransactions Improvements fix: signTransactions Improvements May 19, 2022
@lewis-sqa
Added missing signerId.
51f1f4c
@lewis-sqa
Fixed signing bug.
05ebfda 
- Classic near-api-js schema nightmare.
@lewis-sqa lewis-sqa merged commit c76fc49 into dev May 20, 2022
@lewis-sqa lewis-sqa deleted the sign-transactions-fixes branch May 20, 2022 09:13
@lewis-sqa lewis-sqa mentioned this pull request May 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kujtimprenkuSQA kujtimprenkuSQA kujtimprenkuSQA approved these changes

@amirsaran3 amirsaran3 Awaiting requested review from amirsaran3

Assignees

@lewis-sqa lewis-sqa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewis-sqa @kujtimprenkuSQA