Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Change Builder to Support (esm, cjs, umd) #303

Merged
merged 1 commit into from
May 26, 2022

Conversation

kujtimprenkuSQA
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA commented May 26, 2022

Description

This PR is addresses the issue with some of the frameworks which don't transpile ES6 modules outside the projects /src folder.
By changing the builder to @nrwl/web:rollup we align all the packages to provide support for (esm, cjs, umd) like core and modal-ui

  • Changed builder builder to @nrwl/web:rollup
  • Added formats "format": ["esm", "umd", "cjs"] option.

Closes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@kujtimprenkuSQA kujtimprenkuSQA self-assigned this May 26, 2022
@github-actions github-actions bot changed the title Change Builder to Support (esm, cjs, umd) build: Change Builder to Support (esm, cjs, umd) May 26, 2022
@kujtimprenkuSQA kujtimprenkuSQA merged commit da4b60c into dev May 26, 2022
@kujtimprenkuSQA kujtimprenkuSQA deleted the SQAC-159/change-builder-to-rollup branch May 26, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants