feat: Add Nightly Wallet to Selector #314
Conversation
github-actions
bot
changed the title
|
I have moved eager connect to an internal part of wallet, so front end users will not have to do anything. |
There was a problem hiding this comment.
Few comments from me 👍
I'm having a lot of difficulty importing my wallet using a seed phrase. I think the key pair is resolving correctly but it's lacking a lookup (or sometimes manually requested in some wallets during import) for the accountId. When I attempt to sign a transaction using this demo: https://near-template.vercel.app/, it's hits an error attempting to get the access key information (presumably for the nonce?) as it's passing a long string of characters instead of my testnet NEAR accountId
We use implicit addresses for now we are going to work on custom ones in later releases. Demo only works if you already have some Near on your account since without it, you can't query it. |
|
Fixed most of your comments. Eager connect requires update of extension it will take a couple of days cuz of Chrome. |
|
Extension with fix for eager connect just hit store. @lewis-sqa |
Not sure I fully understand the last part of this. When I import my existing NEAR account that has some NEAR on it, it resolves to an incorrect account id. From what I understand, Nightly is correctly resolving my seed phrase in terms of the key pair, but deriving an implicit account id instead of linking to my I've since created a new account directly through Nightly and sent some NEAR to it so I can test this extension. Are there plans to resolve this issue soon as I can foresee a lot of users having issues importing just like our team has? |
Yes we are going to work on this, but we are still working on best possible UX right now we just use implicit address. |
packages/nightly/src/lib/nightly.ts
Outdated
| const existingAccount = _state.wallet.account.accountId; | ||
|
|
||
| if (existingAccount) { | ||
| const nearAccount: Account = { | ||
| accountId: _state.wallet.account.accountId, | ||
| }; | ||
| return [nearAccount]; | ||
| } |
There was a problem hiding this comment.
We should reuse getAccounts here
There was a problem hiding this comment.
fix 45125a1
Removed |
There was a problem hiding this comment.
This can now be merged.
I should point out that during our testing of this wallet, we noticed the lock feature removes access to the account. The implication of this is Wallet Selector will consider Nightly to be signed out and unselect it as part of the setup logic when the dApp is refreshed for example.
Are there plans to make use of FunctionCall access keys with this wallet to enable "silent" signing of gas-only transactions?
Yes we want to connect this with custom |
Description
This PR adds support for Nightly extension wallet. It works with Solana and Near and has hardware wallet support.
I have added small changes to react template like eager connect for nightly and I think there is bug when wallet is already selected so also fixed that.
Closes # (issue)
Checklist:
Type of change. This type of change is the main reason for the PR.