Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Sqac 149 prevent side effects of multiple calls to setup modal setup wallet selector #316

Conversation

amirsaran3
Copy link
Collaborator

@amirsaran3 amirsaran3 commented Jun 2, 2022

Description

  • Calling setupWalletSelector and setupModal now returns the same instance each time which is stored in memory.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@amirsaran3 amirsaran3 added the change-request A request to change an existing component or feature label Jun 2, 2022
@amirsaran3 amirsaran3 self-assigned this Jun 2, 2022
@github-actions github-actions bot changed the title Sqac 149 prevent side effects of multiple calls to setup modal setup wallet selector refactor: Sqac 149 prevent side effects of multiple calls to setup modal setup wallet selector Jun 2, 2022
@amirsaran3 amirsaran3 merged commit 0a96377 into dev Jun 3, 2022
@amirsaran3 amirsaran3 deleted the SQAC-149-prevent-side-effects-of-multiple-calls-to-setup-modal-setup-wallet-selector branch June 3, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change-request A request to change an existing component or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants