feat: Support Multiple Derivation Paths in UI #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
amirsaran3
previously approved these changes
Jun 6, 2022
lewis-sqa
suggested changes
Jun 6, 2022
Comment on lines
35
to
47
| const handleDerivationPathRemove = (index: number) => { | ||
| const newPaths = [...derivationPaths]; | ||
| newPaths.splice(index, 1); | ||
| setDerivationPaths(newPaths); | ||
| }; | ||
|
|
||
| const handleDerivationPathChange = ( | ||
| index: number, | ||
| e: ChangeEvent<HTMLInputElement> | ||
| ) => { | ||
| const newPaths = [...derivationPaths]; | ||
| newPaths[index].path = e.target.value; | ||
| setDerivationPaths(newPaths); |
There was a problem hiding this comment.
When deriving state from previous state like this, we should use the function parameter for setState
There was a problem hiding this comment.
Thanks for the review, I had some free time and adjusted the code.
lewis-sqa
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes # (issue)
Checklist:
Type of change. This type of change is the main reason for the PR.
Breaking changes