Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ledger Handle Public Key Linked to Multiple Accounts #330

Merged
merged 14 commits into from
Jun 22, 2022
Merged

feat: Ledger Handle Public Key Linked to Multiple Accounts #330

merged 14 commits into from
Jun 22, 2022

Conversation

kujtimprenkuSQA
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA commented Jun 21, 2022 •
edited
Loading

Description

  • Show form to choose a specific accountId if multiple accounts are linked to public key.

Closes #322

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@kujtimprenkuSQA kujtimprenkuSQA self-assigned this Jun 21, 2022
@kujtimprenkuSQA kujtimprenkuSQA marked this pull request as ready for review June 21, 2022 12:41
@github-actions github-actions bot changed the title Ledger Hadnle Public Key Linked to Multiple Accounts feat: Ledger Hadnle Public Key Linked to Multiple Accounts BREAKING CHANGE: _______ Jun 21, 2022
@AmmarHumackicSQA AmmarHumackicSQA changed the title feat: Ledger Hadnle Public Key Linked to Multiple Accounts BREAKING CHANGE: _______ feat: Ledger Handle Public Key Linked to Multiple Accounts BREAKING CHANGE: _______ Jun 21, 2022
@github-actions github-actions bot changed the title feat: Ledger Handle Public Key Linked to Multiple Accounts BREAKING CHANGE: _______ feat: _______ BREAKING CHANGE: _______ Jun 21, 2022
@kujtimprenkuSQA kujtimprenkuSQA changed the title feat: _______ BREAKING CHANGE: _______ Ledger Handle Public Key Linked to Multiple Accounts Jun 21, 2022
@github-actions github-actions bot changed the title Ledger Handle Public Key Linked to Multiple Accounts feat: _______ Jun 21, 2022
@github-actions github-actions bot changed the title feat: _______ feat: Ledger Handle Public Key Linked to Multiple Accounts Jun 21, 2022
lewis-sqa
lewis-sqa reviewed Jun 21, 2022
View reviewed changes
packages/modal-ui/src/lib/components/DerivationPath.tsx Outdated Show resolved Hide resolved
packages/modal-ui/src/lib/components/DerivationPath.tsx Outdated
selectedAccountId?: string;
}

interface LedgerAccount {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the HardwareWalletAccount interface I mentioned in a previous comment instead of this. We'll just need to export it in the core package

packages/modal-ui/src/lib/components/DerivationPath.tsx Show resolved Hide resolved
packages/modal-ui/src/lib/components/DerivationPath.tsx Outdated Show resolved Hide resolved
@kujtimprenkuSQA kujtimprenkuSQA merged commit dbb47b9 into dev Jun 22, 2022
@kujtimprenkuSQA kujtimprenkuSQA deleted the SQAC-170/hadnle-public-key-linked-to-multiple-accounts branch June 22, 2022 16:32
@lewis-sqa lewis-sqa mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewis-sqa lewis-sqa lewis-sqa approved these changes

@amirsaran3 amirsaran3 Awaiting requested review from amirsaran3

Assignees

@kujtimprenkuSQA kujtimprenkuSQA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kujtimprenkuSQA @lewis-sqa