Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NightlyConnect bridge wallet #337

Merged
merged 19 commits into from
Jun 30, 2022

Conversation

NorbertBodziony
Copy link
Contributor

@NorbertBodziony NorbertBodziony commented Jun 28, 2022

Description

Add NightlyConnect bridge wallet.

I have added script to test client side inside scripts folder.

Closes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@NorbertBodziony NorbertBodziony changed the title Nightly connect feat: add NightlyConnect bridge wallet Jun 28, 2022
@NorbertBodziony NorbertBodziony marked this pull request as ready for review June 28, 2022 12:50
@NorbertBodziony
Copy link
Contributor Author

@github-actions github-actions bot changed the title feat: add NightlyConnect bridge wallet feat: add NightlyConnect bridge wallet Jun 28, 2022
Copy link
Contributor

@lewis-sqa lewis-sqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments from me 👍

  • Looks like we've accidentally switched the Sender icon
  • Can Nightly Connect support multiple accounts within a session?

packages/nightly-connect/jest.config.js Outdated Show resolved Hide resolved
packages/nightly-connect/README.md Outdated Show resolved Hide resolved
packages/nightly-connect/src/lib/nightly-connect.ts Outdated Show resolved Hide resolved
packages/nightly-connect/src/lib/nightly-connect.ts Outdated Show resolved Hide resolved
packages/nightly-connect/src/lib/nightly-connect.ts Outdated Show resolved Hide resolved
packages/nightly-connect/src/lib/nightly-connect.ts Outdated Show resolved Hide resolved
packages/nightly-connect/src/lib/nightly-connect.ts Outdated Show resolved Hide resolved
@NorbertBodziony
Copy link
Contributor Author

  • Can Nightly Connect support multiple accounts within a session?

Currently, no.

@lewis-sqa
Copy link
Contributor

@NorbertBodziony Thanks for all your effort on this 👍

@lewis-sqa lewis-sqa merged commit 93c64ae into near:dev Jun 30, 2022
@NorbertBodziony NorbertBodziony deleted the nightly-connect branch June 30, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants