Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed MyNearWallet logo, url, name #346

Merged
merged 4 commits into from
Jul 5, 2022
Merged

fix: Fixed MyNearWallet logo, url, name #346

merged 4 commits into from
Jul 5, 2022

Conversation

followdarko
Copy link
Contributor

@followdarko followdarko commented Jul 4, 2022 •
edited
Loading

Description

This is a fix for MyNearWallet. Changed production URL and displayed name.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

kujtimprenkuSQA
kujtimprenkuSQA suggested changes Jul 5, 2022
View reviewed changes
packages/my-near-wallet/README.md Outdated Show resolved Hide resolved
kujtimprenkuSQA
kujtimprenkuSQA previously approved these changes Jul 5, 2022
View reviewed changes
@kujtimprenkuSQA kujtimprenkuSQA changed the base branch from main to dev July 5, 2022 12:34
@kujtimprenkuSQA kujtimprenkuSQA dismissed their stale review July 5, 2022 12:34

The base branch was changed.

@github-actions github-actions bot changed the title Fixed MyNearWallet logo, url, name fix: Fixed MyNearWallet logo, url, name Jul 5, 2022
@kujtimprenkuSQA kujtimprenkuSQA merged commit c545fe1 into near:dev Jul 5, 2022
@followdarko followdarko deleted the fix/mynearwallet branch July 5, 2022 14:07
@followdarko followdarko mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kujtimprenkuSQA kujtimprenkuSQA kujtimprenkuSQA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@followdarko @kujtimprenkuSQA @lewis-sqa