Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.18.1 #41

Merged
merged 1 commit into from
Jul 23, 2021
Merged

0.18.1 #41

merged 1 commit into from
Jul 23, 2021

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Jul 22, 2021

Major fix is
e34945f

Tested with nearcore

@ailisp ailisp requested a review from matklad July 22, 2021 10:08
@matklad
Copy link
Contributor

matklad commented Jul 22, 2021

Needs to be filed against this branch: https://github.com/near/wasmer/tree/near

@ailisp ailisp changed the base branch from 0.18.0 to near July 23, 2021 00:52
@@ -1157,8 +1157,8 @@ impl ModuleCodeGenerator<X64FunctionCode, X64ExecutionContext, CodegenError>
}
unsafe fn from_cache(artifact: Artifact, _: Token) -> Result<ModuleInner, CacheError> {
let (info, _, memory) = artifact.consume();

let cache_image: CacheImage = BorshDeserialize::try_from_slice(&mut memory.as_slice())
// expected to have additional bytes, so not using try_from_slice here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 comments are good!

@matklad matklad merged commit 0021852 into near Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants