Add Fibonacci benchmark #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes two versions: - Generated from Rust program - Written by hand
MCJOHN974
approved these changes
Dec 1, 2023
| @@ -0,0 +1,3 @@ | |||
| Test,Status,Cycles | |||
| from_rust,compilation failed, | |||
| handwritten_wat,pass,190024 | |||
There was a problem hiding this comment.
LGTM. Just interesting, what is ratio from cycles to seconds?
There was a problem hiding this comment.
Yeah, that would be very interesting to know. I'll be working on figuring this out next.
We basically know that ZK ASM is ~10KHz machine, so now we also need to benchmark that Fibonacci code on normal processor and compute the ratio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two versions:
The Rust-based one does not compile yet due to
br_ifnot being supported oni32values. I will implement it next.There are a few TODOs that I will address with a follow-up PRs to keep this PR focused on one thing.
This is a part of #90