Tweak worst case size #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborg-dev
force-pushed
the
more_comparisons
branch
from
28f08f5 to
ed2131d
Compare
aborg-dev
force-pushed
the
sha_compiles
branch
from
0c64128 to
6d1ed63
Compare
MCJOHN974
reviewed
Dec 4, 2023
| 1_000_000 | ||
| 1_155 |
There was a problem hiding this comment.
Hmm, as I understand, in zkasm each instruction have size 1 (because we usually operate not with the offset but with zkasm lines of code). Maybe we should file issue\todo to rework code offsets in zkasm isa?
MCJOHN974
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last tweak to get SHA256 benchmark to compile.
It still crashes due to memory ops syntax error, but we'll fix that next.