Add support for WASM Global Variables #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborg-dev
force-pushed
the
globals_test
branch
from
22dbb76 to
d2a0184
Compare
aborg-dev
commented
Dec 12, 2023
aborg-dev
commented
Dec 12, 2023
aborg-dev
force-pushed
the
globals_test
branch
4 times, most recently
from
6891254 to
f00d976
Compare
aborg-dev
changed the title
|
LGTM! Just nit: I suggest squash last 3 commits into one |
MCJOHN974
approved these changes
Dec 18, 2023
aborg-dev
force-pushed
the
globals_test
branch
from
42e8daf to
bb5660e
Compare
This commit implements support for global variable loading. The necessary steps are: 1. Generate globals and their initial values in the preamble of ZK ASM 2. In CLIF, generate accesses to globals as memory loads/stores at special "Globals" Symbol + offset which is the index of the global 3. In ISLE, detect accesses to this special "Globals" Symbol and replace them with a Global AMode 4. In Inst::Load and Inst::Store handle the Global AMode with appropriate ZKASM MLOAD and MSTORE This scheme will also extend to heap and table accesses
aborg-dev
force-pushed
the
globals_test
branch
from
bb5660e to
8054cfb
Compare
|
Also, what is performance difference between globals and memory in zkasm? maybe we better should reserve some dedicated memory region for globals, will it faster? (I guess no, but sometimes zkasm provide some surprises) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for global variable loading. The necessary steps are:
MLOADandMSTORE