tests: memory #163
Merged
tests: memory #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this is useful! I'll try to make this test pass on my end. |
aborg-dev
approved these changes
Dec 18, 2023
MCJOHN974
force-pushed
the
viktar/memory-test
branch
from
7ff97ae to
c440a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is hand written, but inspired by spectest. I will add generation of testing wat from spectest in next PRs, maybe when will work on different asserts support (
assert_trap, etc.). For now, I think we can trust this test, and count that memory ops produce valid results in valid situations (but maybe don't throw proper errors in bad situations) as long as we pass the test