Use longer integers to fill ZKASM data section #187
Conversation
Because the constants are 64-bit values, we need to use a different integer type in assignment.
| SP + 5 => SP | ||
| SP + 4 => SP | ||
| C :MSTORE(SP - 1) | ||
| D :MSTORE(SP - 2) | ||
| E :MSTORE(SP - 3) | ||
| B :MSTORE(SP - 4) | ||
| 1n => A ;; LoadConst64 | ||
| 0n => B ;; LoadConst64 | ||
| 10000n => C ;; LoadConst32 | ||
| C => D |
There was a problem hiding this comment.
Why does register allocation become smarter if this zkasm file has no data segment? Naively thinking, shouldn't this zkasm remain unchanged as the code path that was modified isn't hit? For fibonacci/from_rust the length of data_segments is zero in generate_preamble(..., data_segments), so the loop that emits {chunk_data}n ... isn't entered.
There was a problem hiding this comment.
I also find this surprising and have seen this non-stable behavior by the codegen quite a few times. I've filed an issue to investigate it in more detail #190.
Unfortunately, we can't submit the change in this PR without the diff to the generated zkasm files as our tests require the snapshots to match. We should think how to handle this case in the new testing infrastructure. CC @MCJOHN974
Because the constants are 64-bit values, we need to use a different integer type in the assignment.