Adjust SHA256 benchmark code #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few changes: - Using `Sha256::digest` directly instead of creating a mutable hasher object - Using `stack-size=2048` to change the memory address of data region - Simpler equality check of u8 arrays instead of chunked u64 integers See the new code in: https://gist.github.com/akashin/89f2dd88ee267681f87882d27e428e55
nagisa
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few changes:
Sha256::digestdirectly instead of creating a mutable hasher objectstack-size=2048to change the memory address of the data regionSee the new code at: https://gist.github.com/akashin/89f2dd88ee267681f87882d27e428e55