Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing pilcom dependency #200

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

mooori
Copy link

@mooori mooori commented Jan 31, 2024

Code to run tests depends on pilcom:

} = require('pilcom');

Though pilcom is not a dependency. This hasn’t surfaced since zkevm-proverjs depends on pilcom, so it is available anyway. The missing pilcom dependency poses a problem when using a local zkevm-proverjs for debugging (e.g. helper usage).

// package.json: use local `zkevm-proverjs`
"@0xpolygonhermez/zkevm-proverjs": "file:<path>",

@mooori mooori marked this pull request as ready for review January 31, 2024 10:33
@mooori mooori requested review from aborg-dev and MCJOHN974 January 31, 2024 10:33
Copy link

@aborg-dev aborg-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mooori mooori added this pull request to the merge queue Jan 31, 2024
Merged via the queue into near:main with commit 560e62d Jan 31, 2024
19 checks passed
@mooori mooori deleted the fix-dep-pilcom branch January 31, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants