Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zkasm generation into zkasm_codegen.rs #216

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Move zkasm generation into zkasm_codegen.rs #216

merged 1 commit into from
Feb 13, 2024

Conversation

aborg-dev
Copy link

TODO: We need to find a better place for this module

@MCJOHN974
Copy link

TODO: We need to find a better place for this module

Why you think so? Exploring filetests/src I seen files which do very different stuff, all in one directory. Or you want to move away this code from tests folder and put somewhere like cranelift_codegen?

@aborg-dev
Copy link
Author

TODO: We need to find a better place for this module

Why you think so? Exploring filetests/src I seen files which do very different stuff, all in one directory. Or you want to move away this code from tests folder and put somewhere like cranelift_codegen?

Mainly because this functionality is not strictly specific to tests. For example, @mooori is planning to use it in the benchmarking tools that will move outside of filetests folder.
cranelift_codegen might be a reasonable place, specifically cranelift/codegen/src/isa/zkasm, but we need to understand the visibility rules there a bit better.
@nagisa , where would you say is the good location for this functionality?

@aborg-dev aborg-dev mentioned this pull request Feb 13, 2024
@aborg-dev
Copy link
Author

I'll submit it as is to unblock #211, but I'll follow up to move this code to a better location.

@aborg-dev aborg-dev added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit f65f194 Feb 13, 2024
21 checks passed
@aborg-dev aborg-dev deleted the move_codegen branch February 13, 2024 15:57
@nagisa
Copy link
Collaborator

nagisa commented Feb 13, 2024

@nagisa , where would you say is the good location for this functionality?

I don't have any particular suggestions off top of my head right now, but I will suggest to not overthink it now and move the shared code out into a a shared dependency when a 2nd user of this code shows up. Moving the code around in anticipation of this 2nd user may very well end up with that code having a singular user in perpetuity anyhow (if e.g. benchmarks' needs turn out to be different enough and it becomes more sensible for it to have its own copy) with all of the associated complexity.

Not to mention that it'll be much easier to pick an appropriate place for the code once the two users actually materialize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants