Make zkasm_runner public #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborg-dev
force-pushed
the
public_zkasm_runner
branch
from
3229b2d to
73a83d2
Compare
mooori
approved these changes
Mar 5, 2024
| #[serde(rename = "pass")] | ||
| Success, | ||
| /// Program failed during compilation or execution. |
There was a problem hiding this comment.
nit: RuntimeError might not be an ideal name if it can include compilation errors as well.
There was a problem hiding this comment.
True, we would need to rename it in run-tests-zkasm, I'll do that in a separate PR.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
Make zkasm_runner public
aborg-dev
force-pushed
the
public_zkasm_runner
branch
from
73a83d2 to
90d5a03
Compare
aborg-dev
force-pushed
the
public_zkasm_runner
branch
from
90d5a03 to
b4b252e
Compare
aborg-dev
force-pushed
the
public_zkasm_runner
branch
from
b4b252e to
64b3990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the necessary fields public and adds docstrings.
This should address #239 and make #237 easier