Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bench): run profiling from zkasm_runner #248

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

mooori
Copy link

@mooori mooori commented Mar 13, 2024

Motivation

This functionality will be used to add a subcommand to analyze-zkasm which facilitates running instrumented zkASM.

Changes

  • Factors out functionality in zkasm_runner to make it reusable.
  • Adds profile_zkasm[_path] functions and tests them.

Can be reviewed commit-by-commit.

@mooori mooori marked this pull request as ready for review March 13, 2024 12:41
Copy link

@aborg-dev aborg-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mooori mooori added this pull request to the merge queue Mar 15, 2024
Merged via the queue into near:main with commit b320676 Mar 15, 2024
22 checks passed
@mooori mooori deleted the runner-profile branch March 15, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants