New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zkasm: i64.const #63

Closed

MCJOHN974 wants to merge 1 commit into main from viktar/const64

MCJOHN974 commented Nov 1, 2023

No description provided.


          i64.const

2cdd316

MCJOHN974 commented

View reviewed changes

cranelift/codegen/src/isa/zkasm/lower/isle.rs

-                          _ => MInst::load_constant_u64(tmp, val, alloc_tmp),
+                          I32 => MInst::load_constant_u32(tmp, val, alloc_tmp),
+                          I64 => MInst::load_constant_u64(tmp, val, alloc_tmp),
+                          _ => panic!("Not implemented"),

Author

MCJOHN974 Nov 1, 2023

Changed it to panic because I think it is not very good when it don't find an appropriate type and silently changed the type to I64.

MCJOHN974 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet