zkasm: rem #68
Merged
zkasm: rem #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Division for negatives don't work #69. I will care about negatives both for division and reminder in another PR. Signedness also will be covered later |
nagisa
approved these changes
Nov 6, 2023
cranelift/zkasm_data/rem.wat
Outdated
| (module | ||
| (import "env" "assert_eq" (func $assert_eq (param i32) (param i32))) | ||
| (func $main | ||
| i32.const 5 |
There was a problem hiding this comment.
Style nit: mixture of tabs and spaces. Pick one and stick to it. (As far as I know spaces are dominant in wasm ecosystem)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
remopcode and fixes error indivopcode, when division lefts non-zero reminder