Add zkevm-proverjs as a submodule #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
approved these changes
Nov 16, 2023
| @@ -42,6 +42,8 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| with: | |||
| submodules: true | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: '20.8.0' | |||
There was a problem hiding this comment.
Line below can remove the --install-zkwasm argument.
This simplifies the development setup both locally and on CI, as we don't need to clone zkevm-proverjs as an explicit step. Given that we don't plan to directly merge back into wasmtime upstream, I think it's fine to deviate in more major ways from the existing test infrastructure if this gives us productivity gains.
aborg-dev
force-pushed
the
zkevm_submodule
branch
from
671dda6 to
136e126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds zkevm-proverjs as a submodule
This simplifies the development setup both locally and on CI, as we
don't need to clone zkevm-proverjs as an explicit step.
Given that we don't plan to directly merge back into wasmtime upstream, I think it's fine to deviate in more major ways from the existing test infrastructure if this gives us productivity gains.