-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/replace package name #2
Conversation
No linked issues found. Please add the corresponding issues in the pull request description. |
@simoneb I'm not able to add the environment variables required in the failing tests to this repository as I do not have admin rights, but the tests have been passing successfully for me locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Introduction
Functionality is unchanged. Focus has been on reformatting variable and function names, tests and docs to reflect new package name.
Changes
Notes
The auth0 specific tests and relevant environment variables should be moved to the new auth0 specific repository when the new wrapper package is created.
There was a suggestion in this comment that the exposed
auth0Verify
andauth0VerifySecretsCache
Fastify decorators may no longer need to be exposed in this package. They are used internally however so a more involved refactor would be required to remove them. They have so far just been renamed to reflect the new package name.