Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/replace package name #2

Merged
merged 9 commits into from
May 12, 2023
Merged

Refactor/replace package name #2

merged 9 commits into from
May 12, 2023

Conversation

ergusto
Copy link
Member

@ergusto ergusto commented May 11, 2023

Introduction

Functionality is unchanged. Focus has been on reformatting variable and function names, tests and docs to reflect new package name.

Changes

  • Replaces package name in readme with updated package name
  • Replaces package name in package.json with updated package name, and updated package description
  • Replaces package name in tests with updated package name
  • Updated CLI example with renamed arguments
  • Updates Fastify plugin initialisation to use updated package name
  • Updates Fastify decorators to use new plugin name
  • Rewrites exposed type declarations to reflect new package name
  • Replaces plugin decorator usage in tests with updated decorator name

Notes

The auth0 specific tests and relevant environment variables should be moved to the new auth0 specific repository when the new wrapper package is created.

There was a suggestion in this comment that the exposed auth0Verify and auth0VerifySecretsCache Fastify decorators may no longer need to be exposed in this package. They are used internally however so a more involved refactor would be required to remove them. They have so far just been renamed to reflect the new package name.

@ergusto ergusto requested a review from simoneb May 11, 2023 09:22
@github-actions
Copy link
Contributor

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@ergusto
Copy link
Member Author

ergusto commented May 11, 2023

@simoneb I'm not able to add the environment variables required in the failing tests to this repository as I do not have admin rights, but the tests have been passing successfully for me locally.

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants