Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic implementation #1

Merged
merged 11 commits into from
Oct 20, 2020
Merged

Add basic implementation #1

merged 11 commits into from
Oct 20, 2020

Conversation

paolochiodi
Copy link
Member

@paolochiodi paolochiodi commented Oct 15, 2020 •
edited
Loading

@paolochiodi paolochiodi changed the title Add basic implementation WIP: Add basic implementation Oct 15, 2020
mcollina
mcollina previously approved these changes Oct 20, 2020
View reviewed changes
Copy link

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link

CI is failing.

@paolochiodi paolochiodi marked this pull request as ready for review October 20, 2020 08:38
@paolochiodi
Copy link
Member Author

@mcollina CI is fixed, and I expanded CONTRIBUTORS.md

@paolochiodi paolochiodi requested a review from mcollina October 20, 2020 08:45
@paolochiodi paolochiodi changed the title WIP: Add basic implementation Add basic implementation Oct 20, 2020
mcollina
mcollina approved these changes Oct 20, 2020
View reviewed changes
Copy link

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paolochiodi paolochiodi merged commit d3eba82 into master Oct 20, 2020
@paolochiodi paolochiodi deleted the feature/base-functionality branch October 20, 2020 09:50
@optic-release-automation optic-release-automation bot mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@mcdonnelldean mcdonnelldean Awaiting requested review from mcdonnelldean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolochiodi @mcollina