Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move manual backup docs #203

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Move manual backup docs #203

merged 5 commits into from
Oct 28, 2022

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Oct 28, 2022

Reference Issues or PRs

Resolves #118

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 27a0f1c
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/635c0611e66a7900073ad2d1
😎 Deploy Preview https://deploy-preview-203--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kcpevey
Copy link
Contributor Author

kcpevey commented Oct 28, 2022

There are some images that need to be migrated too, but I only want to add those back if you want to keep them.

@viniciusdc
Copy link
Contributor

viniciusdc commented Oct 28, 2022

@kcpevey, the preview is failing, do you know why that might be happening? sorry, found it, I missed this in the logs

Exhaustive list of all broken links found:

- On source page path = /docs/how-tos/manual-backup:
   -> linking to ./awss3curl.md (resolved as: /docs/how-tos/awss3curl.md)
   -> linking to ../installation/login.md (resolved as: /docs/installation/login.md)

Will fix in the review

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing links that do not exists for now, will add replacements later

docs/docs/how-tos/manual-backup.md Outdated Show resolved Hide resolved
docs/docs/how-tos/manual-backup.md Outdated Show resolved Hide resolved
docs/docs/how-tos/manual-backup.md Outdated Show resolved Hide resolved
docs/docs/how-tos/manual-backup.md Outdated Show resolved Hide resolved
@kcpevey
Copy link
Contributor Author

kcpevey commented Oct 28, 2022

Ah, yes. I intended to take care of the CI failures for you after you added your text edits, but it seems you did that first :) I'm happy to take care of any formatting or anything else. I just need help with content.

@viniciusdc
Copy link
Contributor

@kcpevey, the above docs are up to date and will work with the migration. Though I can foresee we will need to add more to this later, once we migrate beta to nebari-v2022.10.1 we will be able to add more to this. For now, to get thing unblocked for the release this is good enough 😄

@viniciusdc viniciusdc merged commit 5a529da into main Oct 28, 2022
@viniciusdc viniciusdc deleted the move_backup_doc branch October 28, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] How to create a manual backup
2 participants