Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for permissions boundary #392

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

aktech
Copy link
Member

@aktech aktech commented Jan 8, 2024

Reference Issues or PRs

Ref: nebari-dev/nebari#2153

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit a593a24
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/65a02d409a2591000744e272
😎 Deploy Preview https://deploy-preview-392--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavithraes pavithraes self-requested a review January 8, 2024 14:52
@pavithraes pavithraes added type: enhancement 💅🏼 New feature or request needs: review 👀 This PR is complete and ready for reviewing labels Jan 8, 2024
@pavithraes pavithraes added this to the 2024.1.1 milestone Jan 9, 2024
@pavithraes
Copy link
Member

@aktech - Thank you for this PR, I think the section added in the PR is a better fit in https://www.nebari.dev/docs/explanations/provider-configuration. I'll take the liberty to push up a commit, please let me know if that's not OK to do for the future! 🌻

Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! LGTM, will merge when CI finishes. :)

@pavithraes pavithraes merged commit 6c8afb4 into main Jan 11, 2024
6 checks passed
@pavithraes pavithraes deleted the permissions-boundary-docs branch January 11, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing type: enhancement 💅🏼 New feature or request
Projects
Status: Done 💪🏾
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants