Skip to content

Commit

Permalink
Remove leading v for release action (#1526)
Browse files Browse the repository at this point in the history
* Remove leading v for release tags

* Add note to release checklist

* Merge release branch into main
  • Loading branch information
iameskild authored Nov 1, 2022
1 parent cd5ff9c commit 938e9bb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/ISSUE_TEMPLATE/release-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,7 @@ Release captain responsible - <@gh_username>
- [ ] [Tag, build and push docker images](https://github.com/nebari-dev/nebari-docker-images/releases/new)
- [ ] [Update and cut release for `nebari-dask` meta package on Conda-Forge.](https://github.com/conda-forge/nebari-dask-feedstock)
- [ ] [Cut PyPI release via GHA release workflow.](https://github.com/nebari-dev/nebari/releases/new)
- Avoid appending `v` to tag.
- Copy release notes from `RELEASE.md`.
- [ ] Merge release branch into `main`
- [ ] [Merge automated release PR for `nebari` on Conda-Forge.](https://github.com/conda-forge/nebari-feedstock)
3 changes: 2 additions & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ jobs:
fetch-depth: 0

- name: Create tag
# if present, remove leading `v`
run: |
echo "NEBARI_TAG=$(git describe --tags)" >> $GITHUB_ENV
echo "NEBARI_TAG=$(git describe --tags | sed 's/^v//')" >> $GITHUB_ENV
echo ${{ env.NEBARI_TAG }}
- name: Build source and binary
Expand Down

0 comments on commit 938e9bb

Please sign in to comment.