-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade conda-store v0.3.10 and simplify specification of image #1130
Conversation
@HarshCasper Oh no, the image Sorry, I didn't realise that both Can you find another way to do all of this so that, essentially, the string There are many approaches you could take. (1) Maybe reinstate all the Terraform variables but with no defaults in the Terraform variable definitions, and then pass through (2) Or keep the string removed from Or there are other possibilities. Personally I think (2) suits us best at this time - we will easily be able to override the image from Python code in the future if we want to. In (2) this means you can't use the lowest level module ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested as above.
Closes #1121 |
* remove conda store image from input_vars * remove terraform variables * uprade image to v0.3.10 * reinstate terraform variables with an image default
Fixes #1126