-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need for AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to be set with Digital Ocean deployment #1344
Conversation
5480c09
to
d0519db
Compare
@viniciusdc this will allow you to remove the need for setting those environment variables for the Digital Ocean deploymet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for updating this @costrouc
@costrouc may I ask if you can do a DO |
… set with Digital Ocean deployment Closes #1343
d0519db
to
3107a65
Compare
I will be testing this on DO, today |
Tested with remote DO deployment and no |
HI @costrouc sorry for the messy revert there, It seems that the destroy command failed with missing environments -- I tried adding a quick workaround, but the error persisted so I reverted the PR. |
to fix the destroy part we just need to add the new terraform state context manager in |
Closes #1343
Changes introduced in this PR:
AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY will be automatically set based on SPACES_ACCESS_KEY_ID and SPACES_SECRET_ACCESS_KEY.
Types of changes
What types of changes does your PR introduce?
Put an
x
in the boxes that applyTesting
Requires testing
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.