Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for python 3.7 in dask environment #1354

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Drop support for python 3.7 in dask environment #1354

merged 1 commit into from
Jul 4, 2022

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented Jun 30, 2022 •
edited
Loading

Closes #1345.

Changes introduced in this PR:

Both the dask-worker environment and the default dask client environment don't have a pinned python version, it's only dictated by the current requirements of qhub-dask. So the only updates necessary are documentation changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

@peytondmurray peytondmurray changed the title [WIP] Drop support for python 3.7 Drop support for python 3.7 in dask environment Jul 4, 2022
@peytondmurray peytondmurray marked this pull request as ready for review July 4, 2022 20:26
viniciusdc
viniciusdc approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peytondmurray peytondmurray merged commit 8246d35 into main Jul 4, 2022
@peytondmurray peytondmurray deleted the drop-py37 branch July 4, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MAINT] - Drop Python 3.7
2 participants
@peytondmurray @viniciusdc