Tweak bashrc #1363
Merged
Tweak bashrc #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciusdc
reviewed
Jul 6, 2022
|
|
||
| NAME=`whoami | cut -d'@' -f1` | ||
|
|
||
| PS1="\[$CYAN\]$NAME:\w\[$RESET\]\$(parse_git_branch) \n\[$GREEN\]\A \$ \[$RESET\]" |
There was a problem hiding this comment.
Hi @dharhas, isn't this conflicting with line 65?
There was a problem hiding this comment.
it overrides line 65. I'm unclear whether setting force_color_prompt will work since bashrc is readonly and I can't test. But I can move this definition over there.
There was a problem hiding this comment.
its okay keeping like that for now
|
@iameskild tested on a Minikube deployment, and everything is running. We can also disregard the falling k8s test as it was successfully deployed locally when he tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1157
Changes introduced in this PR:
Types of changes
What types of changes does your PR introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Documentation
No docs changes required.