Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for helm extension overrides data type issue #1424

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

konkapv
Copy link
Contributor

@konkapv konkapv commented Aug 31, 2022

Changes introduced in this PR:

Giving values in the overrides section in the helm extensions failing with "Inappropriate value for attribute 'values': list of string required". Fix is to accept jsonencoded 'any' value.

Types of changes

What types of changes does your PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Ran manual tests of deployments

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • [ x] Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @konkapv for the PR! I've added just one small fix that needs to be added.

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several tests are failing due to it not being a branch within the quansight/qhub. Looks great to me and thank you @konkapv for the contribution. Look forward to more feedback and PR's 😄

@viniciusdc
Copy link
Contributor

@costrouc ready for merge, @konkapv this looks great. Thanks for the contribution.

@costrouc costrouc merged commit a694703 into nebari-dev:main Sep 1, 2022
@iameskild iameskild added this to the Release v0.4.4 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants