Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lazy import #1721

Merged
merged 1 commit into from
Apr 24, 2023
Merged

remove lazy import #1721

merged 1 commit into from
Apr 24, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Apr 12, 2023

As discussed offline, per title.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@pavithraes pavithraes added the type: maintenance 🛠 Day-to-day maintenance tasks label Apr 24, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier :)

@iameskild iameskild merged commit 0a70b25 into nebari-dev:develop Apr 24, 2023
@pavithraes pavithraes added the status: approved 💪🏾 This PR has been reviewed and approved for merge label Apr 24, 2023
@pmeier pmeier deleted the lazy-import branch April 24, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: approved 💪🏾 This PR has been reviewed and approved for merge type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Development

Successfully merging this pull request may close these issues.

3 participants