Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade command, add RELEASE notes #1789

Merged
merged 6 commits into from
May 5, 2023
Merged

Update upgrade command, add RELEASE notes #1789

merged 6 commits into from
May 5, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

When I was testing 2023.5.1rc1 by upgrading an existing Nebari cluster, I ran into an issue where the deployment failed and complained about an existing service account:

[terraform]: │ Error: serviceaccounts "argo-admin" already exists
[terraform]: │
[terraform]: │   with module.argo-workflows[0].kubernetes_service_account_v1.argo-admin-sa,
[terraform]: │   on modules/kubernetes/services/argo-workflows/main.tf line 150, in resource "kubernetes_service_account_v1" "argo-admin-sa":
[terraform]: │  150: resource "kubernetes_service_account_v1" "argo-admin-sa" {
[terraform]: │
[terraform]: ╵

Although I was able to redeploy and get around this issue, I think it would be safer to have users delete the existing service accounts before deploying. Given that we are already requiring them to delete the CRDs, this adds a minimal additional step.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

nebari/upgrade.py Outdated Show resolved Hide resolved
@iameskild iameskild changed the title Update upgrade command - delete argo-workflows service accounts Update upgrade command, add RELEASE notes May 5, 2023
RELEASE.md Outdated Show resolved Hide resolved
@iameskild iameskild merged commit 1f62863 into develop May 5, 2023
@iameskild iameskild deleted the 20230505eae branch May 5, 2023 22:22
@pavithraes pavithraes added type: enhancement 💅🏼 New feature or request status: approved 💪🏾 This PR has been reviewed and approved for merge labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/Argo area: k8s ⎈ status: approved 💪🏾 This PR has been reviewed and approved for merge type: enhancement 💅🏼 New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants