Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform upgrade to 1.5.7 #1998

Merged
merged 11 commits into from
Sep 19, 2023

Conversation

sblair-metrostar
Copy link
Contributor

Fixes #1913

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Only tested on AWS so far. Needs to be run in each supported cloud environment.

@iameskild
Copy link
Member

I successfully tested this branch on an existing Digital Ocean deployment.

Side note: This version of TF seems to be significantly faster 🎉

@iameskild
Copy link
Member

iameskild commented Sep 15, 2023

Testing this with GCP failed because of the deprecation of module_variable_optional_attrs. Removing the the provider.tf file altogether seems to resolve the issue without any known side-effects; I'm not sure why we were using it in the first place.

I'm removing this provider.tf file in #2010.

@fangchenli fangchenli mentioned this pull request Sep 19, 2023
10 tasks
@iameskild
Copy link
Member

Okay deploying this branch on Azure was also successful. This is ready to be merged 🎉

@iameskild iameskild merged commit 57be4dc into nebari-dev:develop Sep 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - Pin terraform to lattest MPL licensed version
2 participants