Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon to jupyterhub theme. #2222

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

jbouder
Copy link
Contributor

@jbouder jbouder commented Jan 29, 2024

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

  • Favicon added to nebari-design repo
  • Adding favicon to jupyterhub theme to further support theming Nebari

@kcpevey kcpevey requested a review from dcmcand January 29, 2024 14:28
@jbouder
Copy link
Contributor Author

jbouder commented Jan 29, 2024

@dcmcand , The failed job is an existing issue correct? If so, when can we expect to merge this? Thanks!

@kcpevey kcpevey added this to the 2024.2.1 milestone Feb 1, 2024
@kcpevey
Copy link
Contributor

kcpevey commented Feb 2, 2024

yes, the CI failure is outside the scope of this PR. This is ready for review/merging after review.

Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks @jbouder , sorry for the delay in getting to this.

@dcmcand dcmcand merged commit c343d36 into nebari-dev:develop Feb 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants