Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Playwright test to account for changes in JupyterLab UI. #2232

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

marcelovilla
Copy link
Member

Reference Issues or PRs

Fixes #2205

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@viniciusdc
Copy link
Contributor

viniciusdc commented Feb 6, 2024

Summary of changes:

  • Removed JupyterHub Notebook Tests from .github/workflows/test_local_integration.yaml
  • Updates to Playwright test due to recent changes in UI from migration to Jhub app (replacing Jupyterhub)
  • Updates to get_jupyterhub_token to extend _xsrf cookies persistence over proxied requests (aka check for cookies and headers)

for extra ref. see attached issue and latest comment by @marcelovilla #2205 (comment)

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @marcelovilla for getting the tests green again! 🚀

@marcelovilla
Copy link
Member Author

marcelovilla commented Feb 7, 2024

Thank you for your review @viniciusdc!

@aktech would like to get your input on the XSRF token issue and see if matches the way you solved it locally or if there is anything I might be missing.

@aktech
Copy link
Member

aktech commented Feb 8, 2024

Great work @marcelovilla 🎉

@marcelovilla marcelovilla merged commit 4432ee9 into develop Feb 8, 2024
26 checks passed
@marcelovilla marcelovilla deleted the bugfix/playwright-test branch February 8, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[MAINT] - Local Integration Tests failing in CI
3 participants