Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pydantic2 PR fix #2421

Merged
merged 120 commits into from
Apr 22, 2024
Merged

Pydantic2 PR fix #2421

merged 120 commits into from
Apr 22, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Apr 22, 2024 •
edited
Loading

Reference Issues or PRs

Continuation of #2348
Marks a few fields as Optional fields when the default value was already a None value. An error is thrown on instantiation otherwise.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Any other comments?

fangchenli and others added 30 commits August 22, 2023 16:52
@fangchenli
upgrade pydantic
14125a3
@fangchenli
run bump-pydantic
48f26ba
@fangchenli
uncomment Werror
b57c75f
@fangchenli
Merge branch 'develop' into pydantic-v2
250be86
@pre-commit-ci
[pre-commit.ci] Apply automatic pre-commit fixes
7912e37
@fangchenli
Merge branch 'develop' into pydantic-v2
4eb1e08
@fangchenli
update dependency in pyproject
553d021
@fangchenli
Merge branch 'develop' into pydantic-v2
9febc8a
@fangchenli
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
8e33010
@fangchenli
Merge remote-tracking branch 'origin/pydantic-v2' into pydantic-v2
99cb520
@fangchenli
fix typo
8fb92ff
@fangchenli
fix cpu_guarantee type
0967d52
@fangchenli
fix typo
1692797
@fangchenli
Merge branch 'develop' into pydantic-v2
bd76c4d
@fangchenli
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
708d165
@fangchenli
Merge remote-tracking branch 'origin/pydantic-v2' into pydantic-v2
2f99cac
@fangchenli
fix more validation errors
82ec511
@pre-commit-ci
[pre-commit.ci] Apply automatic pre-commit fixes
aba88ec
@fangchenli
fix more validator errors
3e645b4
@fangchenli
Merge remote-tracking branch 'origin/pydantic-v2' into pydantic-v2
ff0682e
@pre-commit-ci
[pre-commit.ci] Apply automatic pre-commit fixes
eaab189
@fangchenli
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
fb90cc6
@fangchenli
resolve conflict
b085e49
@fangchenli
resolve conflict
e520dcc
@fangchenli
resolve conflict
91fb5b4
@pre-commit-ci
[pre-commit.ci] Apply automatic pre-commit fixes
5d0fca4
@fangchenli
fix monkeypatch
2935c1f
@fangchenli
revert printout
961a278
@pre-commit-ci
[pre-commit.ci] Apply automatic pre-commit fixes
f725534
@fangchenli
fix validation error
c543bdd
aktech and others added 25 commits February 14, 2024 17:14
@aktech
Merge branch 'develop' into pydantic-v2
7c5b5cc
@Adam-D-Lewis
Merge branch 'develop' into pydantic2
88b46a8
@Adam-D-Lewis
merge develop
924659d
@Adam-D-Lewis
small fixes
75d8e70
@Adam-D-Lewis
Merge branch 'develop' into pydantic2
a8bab5c
@Adam-D-Lewis
fix arg of classmethod
35252ef
@Adam-D-Lewis
fix req'd vars
436dab7
@Adam-D-Lewis
fix availability zones
283150f
@Adam-D-Lewis
undo signature change
b2dbbd9
@Adam-D-Lewis
fix fn call
082cc41
@Adam-D-Lewis
remove unused var in fn signature
3d6726f
@Adam-D-Lewis
update cpu_limit dtype
7e5891f
@Adam-D-Lewis
update cpu_limit dtype
32ee7ba
@Adam-D-Lewis
revert test changes unrelated to pydantic v2
e1030d8
@Adam-D-Lewis
update for pydantic2
850de95
@Adam-D-Lewis
fix tests
6b2b629
@Adam-D-Lewis
Merge branch 'develop' into pydantic2
473a1ee
@Adam-D-Lewis
replace .dict( with .model_dump(
9d9fd49
@Adam-D-Lewis
Merge branch 'develop' into pydantic2
c4b8c6e
@Adam-D-Lewis
Merge branch 'develop' into pydantic2
89e73aa
@Adam-D-Lewis
Merge branch 'develop' into pydantic2
a3c040b
@Adam-D-Lewis
fix trailing .dump to .model_dump
c976cc2
@Adam-D-Lewis
fix missing optional tags
4bc70ad
@Adam-D-Lewis
fix missing optional tags
f980b06
@Adam-D-Lewis
Merge branch 'develop' into pydantic2
c9703ed
@Adam-D-Lewis Adam-D-Lewis requested a review from a team April 22, 2024 17:00
@Adam-D-Lewis Adam-D-Lewis changed the title Pydantic2 Pydantic2 PR fix Apr 22, 2024
viniciusdc
viniciusdc approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adam-D-Lewis Adam-D-Lewis merged commit 2f85ece into develop Apr 22, 2024
26 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the pydantic2 branch April 22, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Adam-D-Lewis @viniciusdc @fangchenli @aktech