Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HERA_TOKEN env var to user pods #2438

Merged
merged 2 commits into from
May 2, 2024
Merged

add HERA_TOKEN env var to user pods #2438

merged 2 commits into from
May 2, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented May 2, 2024

Reference Issues or PRs

Fixes #2437

There is a sister PR for the docs - nebari-dev/nebari-docs#444

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis marked this pull request as ready for review May 2, 2024 03:42
@Adam-D-Lewis Adam-D-Lewis requested a review from a team May 2, 2024 03:43
@Adam-D-Lewis
Copy link
Member Author

On the local integration test, it seems that the jupyterlab user server took too long https://github.com/nebari-dev/nebari/actions/runs/8918268633/job/24492607383?pr=2438 to spin up, but I don't think anything failed. Retriggering.

@Adam-D-Lewis Adam-D-Lewis added this to the 2024.5.1 milestone May 2, 2024
@viniciusdc viniciusdc merged commit 9077849 into develop May 2, 2024
26 checks passed
@viniciusdc viniciusdc deleted the HERA_TOKEN branch May 2, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - ARGO_TOKEN doesn't work for ARGO CLI
2 participants