Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add overwrite to AWS coredns addon #2538

Merged
merged 1 commit into from
Jul 4, 2024
Merged

add overwrite to AWS coredns addon #2538

merged 1 commit into from
Jul 4, 2024

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Jun 24, 2024

Reference Issues or PRs

Closes #2537

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@dcmcand dcmcand marked this pull request as ready for review June 25, 2024 14:10
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcmcand 🚀 !

@dcmcand dcmcand merged commit 2a1b877 into develop Jul 4, 2024
28 checks passed
@dcmcand dcmcand deleted the issue-2537 branch July 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Allow overwrite on coredns eks addon on conflict
2 participants